Update PHPCS config #177
Merged
Update PHPCS config #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Line 136 needs to be updated from file_system_read to file_system_operations.
Ref: https://github.com/WordPress/WordPress-Coding-Standards/wiki/Upgrade-Guide-to-WordPressCS-3.0.0-for-ruleset-maintainers#excluding-a-group-of-checks
You may also want to remove most of the error code based excludes for WordPress.WP.AlternativeFunctions (line 82 - 86) as those are now just duplicate.
|
@swissspidy I didn't realize you had includes filesystem functions in here as well. Either close or merge PR #178 as needed. |
jrfnl
reviewed
Aug 30, 2023
danielbachhuber
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #175